Remove class baseType interfaces from proxified methods #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert the lazy property proxy to its 5.0.x behavior. This allows to avoid proxifying explicitly implemented interface methods, which are currently not supported by the dynamix proxy (lazy properties proxy). Add test case adapted from gcesena test case. Fixes nhibernate#1628 Co-authored-by: gcesena <[email protected]>
|
I disagree with this change. Please make the DefaultProxyFactory the default proxy factory and run tests. Some will fail. There are specific cases when explicit interfaces are required. |
|
Ok, please ignore previous comment. The implementation is OK actually. |
To be squashed
|
Still. Can you run whole test suite with old proxy factory for proxies? |
I have done it locally with SQL-Server. Only the test checking the default factory was still the static one has failed, since I had changed the default rather than configuring the test. |
hazzik
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the lazy property proxy to its 5.0.x behavior.
This allows to avoid proxifying explicitly implemented interface methods, which are currently not supported by the dynamix proxy (lazy properties proxy).
Add test case adapted from gcesena test case.
Fixes #1628